ndimiduk commented on a change in pull request #775: HBASE-23230 Enforce member
visibility in HRegionServer
URL: https://github.com/apache/hbase/pull/775#discussion_r340860173
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegionServer.java
##########
@@ -272,10 +268,9 @@
private final Cache<Long, Long> executedRegionProcedures =
CacheBuilder.newBuilder().expireAfterAccess(600,
TimeUnit.SECONDS).build();
- // Cache flushing
- protected MemStoreFlusher cacheFlusher;
+ private MemStoreFlusher cacheFlusher;
- protected HeapMemoryManager hMemManager;
+ private HeapMemoryManager hMemManager;
Review comment:
I'm thinking this is for master and branch-2. Any further and these kind of
refactor/cleanup patches end up not being "back ports" but pre-branch rewrites.
I could be persuaded, but you'll have to be pretty decorated in Debate Club.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
