busbey commented on a change in pull request #913: HBASE-23381: Improve Logging
in HBase Commons Package
URL: https://github.com/apache/hbase/pull/913#discussion_r355210580
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -579,11 +571,11 @@ private static void invokeSetStoragePolicy(final
FileSystem fs, final Path path,
toThrow = e;
final String msg = "FileSystem doesn't support setStoragePolicy;
HDFS-6584, HDFS-9345 " +
"not available. This is normal and expected on earlier Hadoop
versions.";
+
+ LOG.debug(msg, e);
Review comment:
This should be in an else block to the if below. We don't want to log both a
debug and a warn statement for the same event.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
