busbey commented on a change in pull request #913: HBASE-23381: Improve Logging
in HBase Commons Package
URL: https://github.com/apache/hbase/pull/913#discussion_r356305150
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java
##########
@@ -579,11 +571,11 @@ private static void invokeSetStoragePolicy(final
FileSystem fs, final Path path,
toThrow = e;
final String msg = "FileSystem doesn't support setStoragePolicy;
HDFS-6584, HDFS-9345 " +
"not available. This is normal and expected on earlier Hadoop
versions.";
+
+ LOG.debug(msg, e);
Review comment:
we have 0 log message unit tests. are we planning to add some? or am I
missing some other context here?
the intention on the current state of "log once at WARN per classloader" is
that these message are important for an operator but we don't want to flood the
logs. The DEBUG level is available in case the system has been running long
enough that we would have rolled off the WARN message and we need a way to
elicit a temporary repeat with a runtime change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
