busbey commented on a change in pull request #913: HBASE-23381: Improve Logging
in HBase Commons Package
URL: https://github.com/apache/hbase/pull/913#discussion_r356215229
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -283,7 +279,14 @@ private synchronized boolean requestCorePoolIncrease() {
// amongst occurrences of the same chore).
if (scheduler.getCorePoolSize() < scheduledChores.size()) {
scheduler.setCorePoolSize(scheduler.getCorePoolSize() + 1);
- printChoreServiceDetails("requestCorePoolIncrease");
+
+ if (LOG.isTraceEnabled()) {
Review comment:
I'm not concerned about four `LOG.trace` calls unless we're in a very hot
path and can see in a profiler that the jit isn't sufficiently taking care of
optimizing us out of worrying about skipping them when trace is off.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
