busbey commented on a change in pull request #913: HBASE-23381: Improve Logging
in HBase Commons Package
URL: https://github.com/apache/hbase/pull/913#discussion_r355210183
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/ChoreService.java
##########
@@ -283,7 +279,14 @@ private synchronized boolean requestCorePoolIncrease() {
// amongst occurrences of the same chore).
if (scheduler.getCorePoolSize() < scheduledChores.size()) {
scheduler.setCorePoolSize(scheduler.getCorePoolSize() + 1);
- printChoreServiceDetails("requestCorePoolIncrease");
+
+ if (LOG.isTraceEnabled()) {
+ LOG.trace("requestCorePoolIncrease");
Review comment:
Why not leave all of this in the method and have it do a proper trace guard?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
