busbey commented on a change in pull request #913: HBASE-23381: Improve Logging
in HBase Commons Package
URL: https://github.com/apache/hbase/pull/913#discussion_r356303779
##########
File path: hbase-common/src/main/java/org/apache/hadoop/hbase/KeyValueUtil.java
##########
@@ -48,8 +46,6 @@
@InterfaceAudience.Private
public class KeyValueUtil {
- private static final Logger LOG =
LoggerFactory.getLogger(KeyValueUtil.class);
Review comment:
that's well and good in principle but only works if we actually log
something about the exception when it's eventually caught. also depending on
the severity it might be needed if we're at risk of stacktrace optimization by
the JVM and log rolling making it so we can't actually get details from here
when it comes time to log the exception elsewhere.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
