anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368415152
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
##########
@@ -1827,7 +1827,8 @@ protected HFileBlock
readBlockDataInternal(FSDataInputStream is, long offset,
@Override
public void setIncludesMemStoreTS(boolean includesMemstoreTS) {
- this.fileContext.setIncludesMvcc(includesMemstoreTS);
+ this.fileContext = new HFileContextBuilder(this.fileContext).
+ withIncludesMvcc(includesMemstoreTS).build();
Review comment:
Do we really need to build new HFileContextBuilder and HFileContext to set?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
