anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368409615
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/encoding/RowIndexSeekerV1.java
##########
@@ -154,19 +153,6 @@ private int binarySearch(Cell seekCell, boolean
seekBefore) {
}
}
- private int compareRows(ByteBuffer row, Cell seekCell) {
Review comment:
I see. This method is moved to CellComparator. Is that required? This impl
here correctly handle things. Within the BBUtils we are handling HBB/DBB. But
in this patch, it is trying to handle in CellComparator which is not good IMHO.
Also within this context we know the passed row BB is sliced for the rk
bytes alone. Within CellComparator we can not have such assumption. So its
better to keep it here only. I believe only this class is having such need for
compares. Any other place?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
