anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368410341
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java
##########
@@ -114,6 +118,11 @@ public HFileContext(HFileContext context) {
this.hfileName = hfileName;
this.columnFamily = columnFamily;
this.tableName = tableName;
+ // If no cellComparator specified, make a guess based off tablename. If
hbase:meta, then should
+ // be the meta table comparator. Comparators are per table.
+ this.cellComparator = cellComparator != null? cellComparator:
+ this.tableName != null?
CellComparatorImpl.getCellComparator(this.tableName):
Review comment:
This I like :-) Our best effort to make things work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
