saintstack commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368604999
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/CellComparator.java
##########
@@ -80,6 +83,24 @@ static CellComparator getInstance() {
*/
int compareRows(Cell cell, byte[] bytes, int offset, int length);
+ /**
+ * @param row ByteBuffer that wraps a row; will read from current position
and will reading all
+ * remaining; will not disturb the ByteBuffer internal state.
+ * @return greater than 0 if leftCell is bigger, less than 0 if rightCell is
bigger, 0 if both
+ * cells are equal
+ */
+ default int compareRows(ByteBuffer row, Cell cell) {
Review comment:
Yes.
Javadoc tries to make this explicit. Should I add more?
" * @param row ByteBuffer that wraps a row; will read from current
position and will reading all
* remaining; will not disturb the ByteBuffer internal state."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
