anoopsjohn commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368413543
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
##########
@@ -319,7 +312,7 @@ public Writer create() throws IOException {
LOG.debug("Unable to set drop behind on {}", path.getName());
}
}
- return new HFileWriterImpl(conf, cacheConf, path, ostream, comparator,
fileContext);
+ return new HFileWriterImpl(conf, cacheConf, path, ostream, fileContext);
Review comment:
So here the comparator class name will be passed within the fileContext from
upper layers. Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
