saintstack commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368613369
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFile.java
##########
@@ -319,7 +312,7 @@ public Writer create() throws IOException {
LOG.debug("Unable to set drop behind on {}", path.getName());
}
}
- return new HFileWriterImpl(conf, cacheConf, path, ostream, comparator,
fileContext);
+ return new HFileWriterImpl(conf, cacheConf, path, ostream, fileContext);
Review comment:
Yes sir. Idea is that there is one place to get comparator to use. Before
this patch, comparator was passed down most of the time but in encoder context
and elsewhere in a few locations, comparator was hardcoded because not passed
from above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
