saintstack commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368615350
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreFileWriter.java
##########
@@ -135,14 +132,16 @@ private StoreFileWriter(FileSystem fs, Path path, final
Configuration conf, Cach
// init bloom context
switch (bloomType) {
case ROW:
- bloomContext = new RowBloomContext(generalBloomFilterWriter,
comparator);
+ bloomContext =
+ new RowBloomContext(generalBloomFilterWriter,
fileContext.getCellComparator());
break;
case ROWCOL:
- bloomContext = new RowColBloomContext(generalBloomFilterWriter,
comparator);
+ bloomContext =
+ new RowColBloomContext(generalBloomFilterWriter,
fileContext.getCellComparator());
Review comment:
Yes sir. One place only instead of hardcodings and guesses at which to use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
