ndimiduk commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r686154814
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/HMaster.java
##########
@@ -1750,10 +1751,16 @@ public boolean skipRegionManagementAction(final String
action) {
return false;
}
- public boolean balance(boolean force) throws IOException {
- if (loadBalancerTracker == null || !loadBalancerTracker.isBalancerOn()) {
+ public boolean balance(BalanceRequest request) throws IOException {
+ return balance(request, false);
+ }
+
+ private boolean balance(BalanceRequest request, boolean isChore) throws
IOException {
Review comment:
That's a reasonable thing for an operator/admin to want to know. There's
a similar concept in the Normalizer in the form of an `isHighPriority` flag,
which is true for a user request and false for a chore-generated request. It
doesn't look like the distinction is logged.
I assume this is something you've wished you'd had in production. If so, I
think we should keep it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
