ndimiduk commented on a change in pull request #3536:
URL: https://github.com/apache/hbase/pull/3536#discussion_r686139319
##########
File path: hbase-protocol-shaded/src/main/protobuf/Master.proto
##########
@@ -292,7 +292,8 @@ message IsInMaintenanceModeResponse {
}
message BalanceRequest {
- optional bool force = 1;
+ optional bool ignore_rit = 1;
Review comment:
>I renamed this so it would reflect the actual functionality of this
argument. The current implementation of force only affects the region in
transition behavior. The fact that it's called force is opaque and
uninformative, and as part of the move to the more descriptive BalanceRequest
it made sense to rename it.
I much prefer your new name, as names go.
> What this could break is if people have custom forks that are directly
accessing the protobufs. I'm assuming the protobufs are
InterfaceAudience.PRIVATE, not sure if that's explicitly documented somewhere.
Our documentation on [Aspirational Semantic
Versioning](http://hbase.apache.org/book.html#hbase.versioning.post10) does not
explicitly discuss the protobuf files themselves, only the wire compatibility
between clients and servers. However, anywhere someone is working on a 3rd
party client, they consume our protobuf files directly, and for those projects,
this would be an incompatible change. _Perhaps_ this falls under the category
of "HBase LimitedPrivate API", similar to coprocessor APIs, which allows us to
make changes on minor releases.
I suggest starting a DISCUSS thread on the dev list, and filing a ticket to
update our documentation according to the conclusion of that thread.
Nice one, Bryan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
