[
https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662479#comment-13662479
]
Sergey Shelukhin commented on HBASE-8497:
-----------------------------------------
left some comments. Main things - I had left a comment before about some
discrepancy ("Hmm... trailerSizeOffset points to the first byte of size 4-byte
buffer").
Also, the size limit was added as safety check. Making it a config parameter
whose only effect is to output a warning that user has no idea what to do with
is not helpful imho. There's no safety check. There's nothing for user to do
really - he can ignore the warnings, or bump the config which basically means
ignore the warning. Might as well remove the entire limit thing :)
> Protobuf WAL also needs a trailer
> ----------------------------------
>
> Key: HBASE-8497
> URL: https://issues.apache.org/jira/browse/HBASE-8497
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs, wal
> Affects Versions: 0.95.1
> Reporter: Enis Soztutar
> Assignee: Himanshu Vashishtha
> Fix For: 0.98.0, 0.95.1
>
> Attachments: HBASE-8497-v0.patch, HBASE-8497-v2.patch,
> HBASE-8497-v3.patch, HBASE-8497-v4.patch, HBASE-8497-v5.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well,
> reserved for later usage.
> Right now, we can we just serialize an empty trailer, but putting more
> metadata there, like range of sequence_id's, region names, table names etc
> might be needed in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
