[
https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662507#comment-13662507
]
Sergey Shelukhin commented on HBASE-8497:
-----------------------------------------
bq. I explained it in the previous rb comment. Please let me know if you have
any follow up question on that. Basically, I removed that trailerOffset as it
was adding some confusion (at least for me). Now, lastPositionToRead points to
the last byte of WALEdit which a reader should read up to in the next method
(inclusive). The trailer starts after this position.
I responded to your response, it seems if the trailer size is 0 with magic/size
present it would point to one byte beyond.
Wrt warning, should it be a constant then?
> Protobuf WAL also needs a trailer
> ----------------------------------
>
> Key: HBASE-8497
> URL: https://issues.apache.org/jira/browse/HBASE-8497
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs, wal
> Affects Versions: 0.95.1
> Reporter: Enis Soztutar
> Assignee: Himanshu Vashishtha
> Fix For: 0.98.0, 0.95.1
>
> Attachments: HBASE-8497-v0.patch, HBASE-8497-v2.patch,
> HBASE-8497-v3.patch, HBASE-8497-v4.patch, HBASE-8497-v5.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well,
> reserved for later usage.
> Right now, we can we just serialize an empty trailer, but putting more
> metadata there, like range of sequence_id's, region names, table names etc
> might be needed in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
