[
https://issues.apache.org/jira/browse/HBASE-8497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13662505#comment-13662505
]
Himanshu Vashishtha commented on HBASE-8497:
--------------------------------------------
Thanks Sergey.
bq. I had left a comment before about some discrepancy ("Hmm...
trailerSizeOffset points to the first byte of size 4-byte buffer")
I explained it in the previous rb comment. Please let me know if you have any
follow up question on that. Basically, I removed that trailerOffset as it was
adding some confusion (at least for me). Now, lastPositionToRead points to the
last byte of WALEdit which a reader should read up to in the next method
(inclusive). The trailer starts after this position.
bq. size limit.
You are right that client can very well ignore it, or bump the config. I think
it is good to have some kind of information on its size.
In the initial version, I used the size in order to skip the trailer if it is
larger than configured and rather used a default one. This could have result in
some erroneous state and made the trailer itself unreliable.
bq. Might as well remove the entire limit thing
That is another option (there was no limit in v1 :)) I am okay with this too.
But yeah, as mentioned above, I am not okay with using a default trailer in
case its size is more than configured.
> Protobuf WAL also needs a trailer
> ----------------------------------
>
> Key: HBASE-8497
> URL: https://issues.apache.org/jira/browse/HBASE-8497
> Project: HBase
> Issue Type: Sub-task
> Components: Protobufs, wal
> Affects Versions: 0.95.1
> Reporter: Enis Soztutar
> Assignee: Himanshu Vashishtha
> Fix For: 0.98.0, 0.95.1
>
> Attachments: HBASE-8497-v0.patch, HBASE-8497-v2.patch,
> HBASE-8497-v3.patch, HBASE-8497-v4.patch, HBASE-8497-v5.patch
>
>
> New Protobuf WAL has a header, but we will probably need a trailer as well,
> reserved for later usage.
> Right now, we can we just serialize an empty trailer, but putting more
> metadata there, like range of sequence_id's, region names, table names etc
> might be needed in the future.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
