[jira] [Work logged] (HIVE-26190) Implement create iceberg table with metadata location

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-26190?focusedWorklogId=764861&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764861
 ]

ASF GitHub Bot logged work on HIVE-26190:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/22 07:29
            Start Date: 02/May/22 07:29
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r862640923


##########
iceberg/iceberg-handler/src/test/java/org/apache/iceberg/mr/hive/TestHiveIcebergStorageHandlerNoScan.java:
##########
@@ -1422,6 +1422,28 @@ public void testAuthzURI() throws TException, 
InterruptedException, URISyntaxExc
     Assert.assertEquals("iceberg://" + hmsTable.getDbName() + "/" + 
hmsTable.getTableName(), uriForAuth.toString());
   }
 
+  @Test
+  public void testCreateTableWithMetadataLocation() throws IOException {
+    Assume.assumeTrue("Create with metadata location is only supported for 
Hive Catalog tables",
+        testTableType.equals(TestTables.TestTableType.HIVE_CATALOG));
+    TableIdentifier sourceIdentifier = TableIdentifier.of("default", "source");
+    Table sourceTable =
+        testTables.createTable(shell, sourceIdentifier.name(), 
HiveIcebergStorageHandlerTestUtils.CUSTOMER_SCHEMA,
+            PartitionSpec.unpartitioned(), FileFormat.PARQUET, 
Collections.emptyList(), 1,
+            ImmutableMap.<String, 
String>builder().put(InputFormatConfig.EXTERNAL_TABLE_PURGE, "FALSE").build());

Review Comment:
   ```
   ImmutableMap.of(InputFormatConfig.EXTERNAL_TABLE_PURGE, "FALSE")
   ```





Issue Time Tracking
-------------------

    Worklog Id:     (was: 764861)
    Time Spent: 0.5h  (was: 20m)

> Implement create iceberg table with metadata location
> -----------------------------------------------------
>
>                 Key: HIVE-26190
>                 URL: https://issues.apache.org/jira/browse/HIVE-26190
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> We should support the following syntax
> {code:sql}
> CREATE TABLE ... TBLPROPERTIES('metadata_location='some_location'){code}
> This would allow us to create an iceberg table by reusing an already existing 
> metadata. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)