[
https://issues.apache.org/jira/browse/HIVE-26190?focusedWorklogId=766538&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766538
]
ASF GitHub Bot logged work on HIVE-26190:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 09:40
Start Date: 05/May/22 09:40
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r865729109
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -196,9 +201,15 @@ public void
commitCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTabl
if (Catalogs.hiveCatalog(conf, catalogProperties)) {
catalogProperties.put(TableProperties.ENGINE_HIVE_ENABLED, true);
}
-
- Catalogs.createTable(conf, catalogProperties);
+ String metadataLocation =
hmsTable.getParameters().get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP);
Review Comment:
Could we store the location in a `HiveIcebegMetaHook` attribute instead of
sending it to HMS?
Issue Time Tracking
-------------------
Worklog Id: (was: 766538)
Time Spent: 2h (was: 1h 50m)
> Implement create iceberg table with metadata location
> -----------------------------------------------------
>
> Key: HIVE-26190
> URL: https://issues.apache.org/jira/browse/HIVE-26190
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> We should support the following syntax
> {code:sql}
> CREATE TABLE ... TBLPROPERTIES('metadata_location='some_location'){code}
> This would allow us to create an iceberg table by reusing an already existing
> metadata.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
