[jira] [Work logged] (HIVE-26190) Implement create iceberg table with metadata location

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-26190?focusedWorklogId=764862&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-764862
 ]

ASF GitHub Bot logged work on HIVE-26190:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 02/May/22 07:30
            Start Date: 02/May/22 07:30
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r862641625


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -78,6 +78,7 @@ private InputFormatConfig() {
   public static final String CTAS_TABLE_NAME = "iceberg.mr.ctas.table.name";
   public static final String SELECTED_COLUMNS = "iceberg.mr.selected.columns";
   public static final String EXTERNAL_TABLE_PURGE = "external.table.purge";
+  public static final String METADATA_LOCATION = "metadata_location";

Review Comment:
   This feels problematic to me, as it is already stored in the 
HiveTableOperations



##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/InputFormatConfig.java:
##########
@@ -78,6 +78,7 @@ private InputFormatConfig() {
   public static final String CTAS_TABLE_NAME = "iceberg.mr.ctas.table.name";
   public static final String SELECTED_COLUMNS = "iceberg.mr.selected.columns";
   public static final String EXTERNAL_TABLE_PURGE = "external.table.purge";
+  public static final String METADATA_LOCATION = "metadata_location";

Review Comment:
   This feels problematic to me, as it is already stored in the 
HiveTableOperations, let's talk about this





Issue Time Tracking
-------------------

    Worklog Id:     (was: 764862)
    Time Spent: 40m  (was: 0.5h)

> Implement create iceberg table with metadata location
> -----------------------------------------------------
>
>                 Key: HIVE-26190
>                 URL: https://issues.apache.org/jira/browse/HIVE-26190
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> We should support the following syntax
> {code:sql}
> CREATE TABLE ... TBLPROPERTIES('metadata_location='some_location'){code}
> This would allow us to create an iceberg table by reusing an already existing 
> metadata. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)