[
https://issues.apache.org/jira/browse/HIVE-26190?focusedWorklogId=766536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766536
]
ASF GitHub Bot logged work on HIVE-26190:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 05/May/22 09:37
Start Date: 05/May/22 09:37
Worklog Time Spent: 10m
Work Description: pvary commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r865725793
##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergMetaHook.java:
##########
@@ -183,6 +183,11 @@ public void
preCreateTable(org.apache.hadoop.hive.metastore.api.Table hmsTable)
catalogProperties.put(InputFormatConfig.TABLE_SCHEMA,
SchemaParser.toJson(schema));
catalogProperties.put(InputFormatConfig.PARTITION_SPEC,
PartitionSpecParser.toJson(spec));
setCommonHmsTablePropertiesForIceberg(hmsTable);
+
+
hmsTable.getParameters().computeIfPresent(BaseMetastoreTableOperations.METADATA_LOCATION_PROP,
(k, v) -> {
Review Comment:
is this equivalent with this:
```
if
(hmsTable.getParameters().get(BaseMetastoreTableOperations.METADATA_LOCATION_PROP)
!= null) {
hmsTable.getParameters().put(CREATE_HMS_TABLE_IN_HOOK, "true");
}
```
Issue Time Tracking
-------------------
Worklog Id: (was: 766536)
Time Spent: 1h 40m (was: 1.5h)
> Implement create iceberg table with metadata location
> -----------------------------------------------------
>
> Key: HIVE-26190
> URL: https://issues.apache.org/jira/browse/HIVE-26190
> Project: Hive
> Issue Type: Improvement
> Reporter: László Pintér
> Assignee: László Pintér
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> We should support the following syntax
> {code:sql}
> CREATE TABLE ... TBLPROPERTIES('metadata_location='some_location'){code}
> This would allow us to create an iceberg table by reusing an already existing
> metadata.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
