[jira] [Work logged] (HIVE-26190) Implement create iceberg table with metadata location

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/HIVE-26190?focusedWorklogId=766532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-766532
 ]

ASF GitHub Bot logged work on HIVE-26190:
-----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/May/22 09:33
            Start Date: 05/May/22 09:33
    Worklog Time Spent: 10m 
      Work Description: pvary commented on code in PR #3259:
URL: https://github.com/apache/hive/pull/3259#discussion_r865722866


##########
iceberg/iceberg-handler/src/main/java/org/apache/iceberg/mr/Catalogs.java:
##########
@@ -137,26 +137,12 @@ private static Table loadTable(Configuration conf, String 
tableIdentifier, Strin
    * @return the created Iceberg table
    */
   public static Table createTable(Configuration conf, Properties props) {
-    String schemaString = props.getProperty(InputFormatConfig.TABLE_SCHEMA);
-    Preconditions.checkNotNull(schemaString, "Table schema not set");
-    Schema schema = 
SchemaParser.fromJson(props.getProperty(InputFormatConfig.TABLE_SCHEMA));
-
-    String specString = props.getProperty(InputFormatConfig.PARTITION_SPEC);
-    PartitionSpec spec = PartitionSpec.unpartitioned();
-    if (specString != null) {
-      spec = PartitionSpecParser.fromJson(schema, specString);
-    }
-
+    Schema schema = getSchema(props);
+    PartitionSpec spec = getPartitionSpec(props, schema);

Review Comment:
   nit: spec(props, schema)





Issue Time Tracking
-------------------

    Worklog Id:     (was: 766532)
    Time Spent: 1h 20m  (was: 1h 10m)

> Implement create iceberg table with metadata location
> -----------------------------------------------------
>
>                 Key: HIVE-26190
>                 URL: https://issues.apache.org/jira/browse/HIVE-26190
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: László Pintér
>            Assignee: László Pintér
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> We should support the following syntax
> {code:sql}
> CREATE TABLE ... TBLPROPERTIES('metadata_location='some_location'){code}
> This would allow us to create an iceberg table by reusing an already existing 
> metadata. 



--
This message was sent by Atlassian Jira
(v8.20.7#820007)