VGalaxies commented on code in PR #2277:
URL:
https://github.com/apache/incubator-hugegraph/pull/2277#discussion_r1296625306
##########
hugegraph-dist/pom.xml:
##########
@@ -212,6 +229,19 @@
</configuration>
</execution>
</executions>
+ <dependencies>
+ <dependency>
+ <groupId>ant-contrib</groupId>
+ <artifactId>ant-contrib</artifactId>
+ <version>1.0b3</version>
+ <exclusions>
+ <exclusion>
+ <groupId>ant</groupId>
+ <artifactId>ant</artifactId>
+ </exclusion>
+ </exclusions>
Review Comment:
To avoid downloading swagger-ui on non-Linux platforms, the utilization of
the `if` tag from `ant-contrib` is demonstrated here.
An alternative
[approach](https://maven.apache.org/guides/introduction/introduction-to-profiles.html#OS)
could involve controlling profile activation through the `os` attribute.
**However, it seems tricky to activate the same profile for both Mac and Linux
simultaneously.**
> ref: https://issues.apache.org/jira/browse/MNG-3328
**In order to reuse the configuration of the `maven-antrun-plugin`**, I'm
considering setting up the `download-swagger-ui` configuration in the root
pom's `pluginManagement`. In this way, it can be reused for `hugegraph-dist`,
see [`1534605`
(#2277)](https://github.com/apache/incubator-hugegraph/pull/2277/commits/1534605ae8ab64a2d601fd3930ec19967bf8cd27).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
