imbajin commented on code in PR #2277:
URL:
https://github.com/apache/incubator-hugegraph/pull/2277#discussion_r1302381882
##########
pom.xml:
##########
@@ -676,8 +747,118 @@
</gpgArguments>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-all</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <DependencyConvergence/>
+ <requireJavaVersion>
+ <version>[1.8,12)</version>
+ </requireJavaVersion>
+ <requireMavenVersion>
+ <version>[3.5.0,)</version>
+ </requireMavenVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>assembly-hugegraph</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-assembly-plugin</artifactId>
+ </plugin>
</plugins>
</build>
+ <activation>
+ <file>
+ <exists>dist.sh</exists>
+ </file>
+ </activation>
+ </profile>
+ <profile>
+ <id>unix-package</id>
+ <build>
+ <plugins>
+ <plugin>
+ <artifactId>maven-antrun-plugin</artifactId>
+ </plugin>
+ </plugins>
+ </build>
+ <activation>
+ <os>
+ <family>unix</family>
+ <name>Linux</name>
Review Comment:
`Unix` VS `MacOS` seems not right? (better to use `Linux` directly)
##########
pom.xml:
##########
@@ -676,8 +747,118 @@
</gpgArguments>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-all</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <DependencyConvergence/>
+ <requireJavaVersion>
+ <version>[1.8,12)</version>
+ </requireJavaVersion>
+ <requireMavenVersion>
+ <version>[3.5.0,)</version>
+ </requireMavenVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>assembly-hugegraph</id>
Review Comment:
after we move the profile, what's the proper building command?
Before:
`mvn clean install -Papache-release -DskipTests` for building
`apache-release` source/binary package
Now: ?
##########
pom.xml:
##########
@@ -453,6 +453,77 @@
<consoleOutput>true</consoleOutput>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <version>2.4</version>
+ <executions>
+ <execution>
+ <id>assembly-hugegraph</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <attach>false</attach>
+ <appendAssemblyId>false</appendAssemblyId>
+ <outputDirectory>${top.level.dir}
+ </outputDirectory>
+ <descriptor>
+ ${assembly.descriptor.dir}/assembly.xml
+ </descriptor>
+ <finalName>${final.name}</finalName>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-antrun-plugin</artifactId>
+ <version>1.8</version>
+ <executions>
+ <execution>
+ <id>download-swagger-ui</id>
+ <phase>prepare-package</phase>
Review Comment:
seems this step will not be inherited by other modules?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
