[GitHub] [incubator-hugegraph] VGalaxies commented on a diff in pull request #2277: chore(dist): replace wget to curl to download swagger-ui

Tue, 22 Aug 2023 21:37:26 -0700 


VGalaxies commented on code in PR #2277:
URL: 
https://github.com/apache/incubator-hugegraph/pull/2277#discussion_r1302471977


##########
pom.xml:
##########
@@ -676,8 +747,118 @@
                             </gpgArguments>
                         </configuration>
                     </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-enforcer-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>enforce-all</id>
+                                <goals>
+                                    <goal>enforce</goal>
+                                </goals>
+                                <configuration>
+                                    <rules>
+                                        <DependencyConvergence/>
+                                        <requireJavaVersion>
+                                            <version>[1.8,12)</version>
+                                        </requireJavaVersion>
+                                        <requireMavenVersion>
+                                            <version>[3.5.0,)</version>
+                                        </requireMavenVersion>
+                                    </rules>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+        <profile>
+            <id>assembly-hugegraph</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-assembly-plugin</artifactId>
+                    </plugin>
                 </plugins>
             </build>
+            <activation>
+                <file>
+                    <exists>dist.sh</exists>
+                </file>
+            </activation>
+        </profile>
+        <profile>
+            <id>unix-package</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-antrun-plugin</artifactId>
+                    </plugin>
+                </plugins>
+            </build>
+            <activation>
+                <os>
+                    <family>unix</family>
+                    <name>Linux</name>

Review Comment:
   looks like the `family` field can only be `unix` or `mac` 🤔
   
   
![image](https://github.com/apache/incubator-hugegraph/assets/79143929/559d9b5f-7874-4b21-9f20-fd408f135f47)



##########
pom.xml:
##########
@@ -676,8 +747,118 @@
                             </gpgArguments>
                         </configuration>
                     </plugin>
+                    <plugin>
+                        <groupId>org.apache.maven.plugins</groupId>
+                        <artifactId>maven-enforcer-plugin</artifactId>
+                        <executions>
+                            <execution>
+                                <id>enforce-all</id>
+                                <goals>
+                                    <goal>enforce</goal>
+                                </goals>
+                                <configuration>
+                                    <rules>
+                                        <DependencyConvergence/>
+                                        <requireJavaVersion>
+                                            <version>[1.8,12)</version>
+                                        </requireJavaVersion>
+                                        <requireMavenVersion>
+                                            <version>[3.5.0,)</version>
+                                        </requireMavenVersion>
+                                    </rules>
+                                </configuration>
+                            </execution>
+                        </executions>
+                    </plugin>
+                </plugins>
+            </build>
+        </profile>
+        <profile>
+            <id>assembly-hugegraph</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-assembly-plugin</artifactId>
+                    </plugin>
                 </plugins>
             </build>
+            <activation>
+                <file>
+                    <exists>dist.sh</exists>
+                </file>
+            </activation>
+        </profile>
+        <profile>
+            <id>unix-package</id>
+            <build>
+                <plugins>
+                    <plugin>
+                        <artifactId>maven-antrun-plugin</artifactId>
+                    </plugin>
+                </plugins>
+            </build>
+            <activation>
+                <os>
+                    <family>unix</family>
+                    <name>Linux</name>

Review Comment:
   looks like the `family` field can only be `unix` or `mac` 🤔
   
   
![image](https://github.com/apache/incubator-hugegraph/assets/79143929/559d9b5f-7874-4b21-9f20-fd408f135f47)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to