VGalaxies commented on code in PR #2277:
URL:
https://github.com/apache/incubator-hugegraph/pull/2277#discussion_r1301391035
##########
pom.xml:
##########
@@ -453,6 +453,30 @@
<consoleOutput>true</consoleOutput>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-assembly-plugin</artifactId>
+ <version>2.4</version>
+ <executions>
+ <execution>
+ <id>assembly-hugegraph</id>
+ <phase>package</phase>
+ <goals>
+ <goal>single</goal>
+ </goals>
+ <configuration>
+ <attach>false</attach>
+ <appendAssemblyId>false</appendAssemblyId>
+ <outputDirectory>${top.level.dir}
+ </outputDirectory>
+ <descriptor>
+ ${assembly.descriptor.dir}/assembly.xml
+ </descriptor>
Review Comment:
As Maven operates within the context of the current module when executing
goals, the paths specified here are relative to the `hugegraph-dist` directory
and can correctly resolve the `assembly.descriptor.dir` property declared
within `hugegraph-dist`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
