VGalaxies commented on code in PR #2277:
URL:
https://github.com/apache/incubator-hugegraph/pull/2277#discussion_r1302507017
##########
pom.xml:
##########
@@ -676,8 +747,118 @@
</gpgArguments>
</configuration>
</plugin>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-enforcer-plugin</artifactId>
+ <executions>
+ <execution>
+ <id>enforce-all</id>
+ <goals>
+ <goal>enforce</goal>
+ </goals>
+ <configuration>
+ <rules>
+ <DependencyConvergence/>
+ <requireJavaVersion>
+ <version>[1.8,12)</version>
+ </requireJavaVersion>
+ <requireMavenVersion>
+ <version>[3.5.0,)</version>
+ </requireMavenVersion>
+ </rules>
+ </configuration>
+ </execution>
+ </executions>
+ </plugin>
+ </plugins>
+ </build>
+ </profile>
+ <profile>
+ <id>assembly-hugegraph</id>
Review Comment:
> When a profile is activated through the **implicit profile activation**
mechanism, the **explicit profile activation mechanism** within the same pom
becomes ineffective.
>
> So it's necessary to explicitly specify the profiles:
>
> ```shell
> mvn clean install -Papache-release,assembly-hugegraph,tar-package
-DskipTests
> ```
>
> > ref:
[maven.apache.org/guides/introduction/introduction-to-profiles.html#explicit-profile-activation](https://maven.apache.org/guides/introduction/introduction-to-profiles.html#explicit-profile-activation)
The relevant scripts and documentation need to be updated later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
