bitflicker64 commented on code in PR #3290:
URL: https://github.com/apache/hugegraph/pull/3290#discussion_r4242761386
##########
helm/hugegraph/templates/server-deployment.yaml:
##########
@@ -146,8 +146,8 @@ spec:
# 401 to every request made with it. Temporary: drop this check,
# the colon case above and the matching schema pattern once the
# Server decodes Basic auth as UTF-8 and splits the credential on
- # its first colon only (TODO in AuthenticationFilter,
- # apache/hugegraph#3260).
+ # its first colon only (apache/hugegraph#3284) in the image this
Review Comment:
Minor: `helm/hugegraph/README.md` lines 814 to 817 at this head still say
"the TODOs at the decoding site and at `encode_prop_value` are in
apache/hugegraph#3260". This PR deletes the decoding-site TODO from
`AuthenticationFilter` and repoints this wrapper comment to #3284, so after
merge the README describes a TODO that is no longer in the tree and the chart
cites two references for one condition. The rest of that paragraph describes
the published image and can stay. Requested change: update that parenthetical
to match, for example "(Server side: apache/hugegraph#3284, once the image this
chart deploys includes that fix; the TODO at `encode_prop_value` is in
apache/hugegraph#3260)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
