imbajin commented on code in PR #3290:
URL: https://github.com/apache/hugegraph/pull/3290#discussion_r4246394988
##########
hugegraph-server/hugegraph-test/src/main/java/org/apache/hugegraph/api/CypherApiTest.java:
##########
@@ -411,6 +471,33 @@ public void testSpecifiedGraphRouting() {
}
}
+ private String createAuth(Deque<String[]> created, String path, String
body) {
+ String content = assertResponseStatus(201, client().post(path, body));
+ String id = assertJsonContains(content, "id");
+ created.push(new String[]{path, id});
+ return id;
+ }
+
+ private void deleteAuth(Deque<String[]> created) {
+ while (!created.isEmpty()) {
+ String[] entry = created.pop();
+ client().delete(entry[0], entry[1]);
Review Comment:
🧹 Blocking: no. Summary: This helper discards each DELETE response, so a
failed final cleanup can leave fixed-name auth records behind while the test
succeeds. Evidence: RestClient.delete() returns a Response, and
BaseApiTest.clearData() clears only graph/schema data. Please assert each
deletion's expected status while continuing the remaining cleanup, so auth
cleanup failures fail the test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
