arshilkxwork commented on code in PR #3290:
URL: https://github.com/apache/hugegraph/pull/3290#discussion_r4243119366
##########
helm/hugegraph/templates/server-deployment.yaml:
##########
@@ -146,8 +146,8 @@ spec:
# 401 to every request made with it. Temporary: drop this check,
# the colon case above and the matching schema pattern once the
# Server decodes Basic auth as UTF-8 and splits the credential on
- # its first colon only (TODO in AuthenticationFilter,
- # apache/hugegraph#3260).
+ # its first colon only (apache/hugegraph#3284) in the image this
Review Comment:
Thank you. Commit cd10ba8 updates that parenthetical in
`helm/hugegraph/README.md` as suggested. It now refers to apache/hugegraph#3284
for the Server side, once the image the chart deploys includes that fix, and
keeps the reference to the `encode_prop_value` TODO in apache/hugegraph#3260,
which remains in `docker-entrypoint.sh`. The rest of the paragraph, which
describes the published image, is unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
