imbajin commented on code in PR #3322:
URL: https://github.com/apache/hugegraph/pull/3322#discussion_r4253126781
##########
helm/hugegraph/templates/server-deployment.yaml:
##########
@@ -258,6 +258,14 @@ spec:
fieldPath: status.podIP
- name: HG_SERVER_BACKEND
value: {{ .Values.server.backend | quote }}
+ {{- if ne (.Values.server.serviceId | default "DEFAULT") "DEFAULT"
}}
+ - name: HG_SERVER_SERVICE_ID
+ value: {{ .Values.server.serviceId | replace "$" "$$" | quote }}
+ {{- end }}
+ {{- if ne (.Values.server.graphSpace | default "DEFAULT")
"DEFAULT" }}
+ - name: HG_SERVER_GRAPHSPACE
+ value: {{ .Values.server.graphSpace | quote }}
Review Comment:
Could you recheck the blocking conclusion against
HugeGremlinServer.prepare()? At this head, it scans the local graph directory
and registers DEFAULT-<name> before REST loads PD metadata:
https://github.com/apache/hugegraph/blob/91b00d294a2dd232166a00b0d7ccfd820f91ec73/hugegraph-server/hugegraph-dist/src/main/java/org/apache/hugegraph/dist/HugeGremlinServer.java#L60-L75
. Stock packaging retains hugegraph.properties, so a successfully loaded local
graph can supply DEFAULT-hugegraph independently of server.graphspace. The
cited GraphManager filter covers PD metadata loading; /gremlin forwards to
Gremlin’s separate graph manager for alias resolution.
A custom configuration without that local binding can still fail, and the
current hook does not validate selected-space graph health. These are narrower
conditions than every non-default graphSpace failing. Two independent source
checks reached this conclusion; no cluster reproduction was run. A stock-config
versus deliberately default-free-config control would distinguish the cases
before changing or skipping the sweep. Deriving team_a-hugegraph alone is also
insufficient unless that graph exists.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
