imbajin commented on code in PR #3322:
URL: https://github.com/apache/hugegraph/pull/3322#discussion_r4259352876
##########
helm/hugegraph/values.schema.json:
##########
@@ -762,6 +762,23 @@
"probes"
],
"properties": {
+ "serviceId": {
+ "type": "string",
+ "minLength": 1,
+ "pattern": "^[ -~]+$",
+ "description": "Printable ASCII PD service name (bytes 0x20-0x7E),
including spaces and backslashes. DEFAULT preserves the image config."
+ },
+ "graphSpace": {
+ "type": "string",
+ "minLength": 1,
+ "pattern": "^(DEFAULT|[a-z][a-z0-9_]{0,47})$",
+ "description": "Existing PD graph space: DEFAULT or up to 48
lowercase letters, digits and underscores, starting with a letter. DEFAULT
preserves the image config."
+ },
+ "testGraphAlias": {
+ "type": "string",
+ "pattern":
"^(DEFAULT|[a-z][a-z0-9_]{0,47})-[A-Za-z][A-Za-z0-9_]{0,47}$",
Review Comment:
⚠️ Important. Blocking: no. Summary: `server.testGraphAlias` permits
uppercase graph names that the Server cannot create, so validation succeeds but
the test hook will retry and fail. Evidence: `GraphManager.NAME_REGEX` and
`checkGraphName()` accept only lowercase names. Please restrict the graph-name
part to the same name rule and add a rejection case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
