imbajin commented on code in PR #3322:
URL: https://github.com/apache/hugegraph/pull/3322#discussion_r4261266458
##########
helm/hugegraph/values.schema.json:
##########
@@ -762,6 +762,23 @@
"probes"
],
"properties": {
+ "serviceId": {
+ "type": "string",
+ "minLength": 1,
+ "pattern": "^[ -~]+$",
Review Comment:
Confirmed the two read-path defects and fixed them without restricting
existing service IDs. Service metadata now takes the complete name after its
known namespace prefix, and graph-space clearing splits the space/service cache
key only once. Names such as `team/analytics` and `analytics-prod` remain
intact; the stored keys, service format and locking protocol are unchanged.
The regression exercises the actual metadata write, reload and removal
methods, plus the actual graph-space clear/drop path. It distinguishes the
slash-containing name from `analytics` and verifies that clearing one space
removes its complete service names while preserving another space. The metadata
storage dependency is controlled in that test; this is not a stock PD/HStore
deployment result. Docker and Helm guidance now matches the behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
