imbajin commented on code in PR #3322:
URL: https://github.com/apache/hugegraph/pull/3322#discussion_r4261269014
##########
helm/hugegraph/values.schema.json:
##########
@@ -762,6 +762,23 @@
"probes"
],
"properties": {
+ "serviceId": {
+ "type": "string",
+ "minLength": 1,
+ "pattern": "^[ -~]+$",
+ "description": "Printable ASCII PD service name (bytes 0x20-0x7E),
including spaces and backslashes. DEFAULT preserves the image config."
+ },
+ "graphSpace": {
+ "type": "string",
+ "minLength": 1,
+ "pattern": "^(DEFAULT|[a-z][a-z0-9_]{0,47})$",
+ "description": "Existing PD graph space: DEFAULT or up to 48
lowercase letters, digits and underscores, starting with a letter. DEFAULT
preserves the image config."
+ },
+ "testGraphAlias": {
+ "type": "string",
+ "pattern":
"^(DEFAULT|[a-z][a-z0-9_]{0,47})-[A-Za-z][A-Za-z0-9_]{0,47}$",
Review Comment:
This finding conflates REST-created graph names with existing Gremlin
binding names. `GraphManager.NAME_REGEX` applies to dynamic graph creation,
while `ConfigUtil.scanGraphsDir()` and `HugeFactory.checkGraphName()` accept
case-insensitive local configuration names. `HugeGremlinServer.prepare()`
registers the binding using that file name.
Verified with the actual Server producer classes and stock WsAndHttp
channelizer: `Demo.properties` registered `DEFAULT-Demo`, and a real HTTP query
through that alias succeeded with unchanged graph data. The graph's internal
name was `demo`; the lowercase alias `DEFAULT-demo` and an absent alias were
not bound and failed. The hook therefore keeps the existing
uppercase-compatible alias rule, with a positive chart regression and guidance
to match the actual binding case. This demonstrates static local binding
compatibility, not a guarantee that PD dynamic creation accepts uppercase graph
names.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
