imbajin commented on code in PR #3322:
URL: https://github.com/apache/hugegraph/pull/3322#discussion_r4253126781
##########
helm/hugegraph/templates/server-deployment.yaml:
##########
@@ -258,6 +258,14 @@ spec:
fieldPath: status.podIP
- name: HG_SERVER_BACKEND
value: {{ .Values.server.backend | quote }}
+ {{- if ne (.Values.server.serviceId | default "DEFAULT") "DEFAULT"
}}
+ - name: HG_SERVER_SERVICE_ID
+ value: {{ .Values.server.serviceId | replace "$" "$$" | quote }}
+ {{- end }}
+ {{- if ne (.Values.server.graphSpace | default "DEFAULT")
"DEFAULT" }}
+ - name: HG_SERVER_GRAPHSPACE
+ value: {{ .Values.server.graphSpace | quote }}
Review Comment:
Added `server.testGraphAlias` so the hook can query an explicitly selected,
existing Gremlin graph binding, such as `team_a-demo`. The default remains
`DEFAULT-hugegraph`, including saved values that lack the new field.
Authentication, the complete per-Pod sweep, replica floor and retries are
unchanged; an unknown alias still fails.
`server.graphSpace` selects the Server's PD service assignment. Gremlin can
also register local `DEFAULT-*` bindings independently, so a non-default
assignment does not always make the default alias fail. The hook does not infer
or create a graph from that assignment. The chart guide now explains the
target-graph prerequisite and checking the graph/alias before restarting a Pod;
paired website guidance is in [Doc
#517](https://github.com/apache/hugegraph-doc/pull/517).
Verified this on a real standalone Server with StandardAuthenticator and
RocksDB, with no `hugegraph` binding: the old default hook failed, selecting
the existing `DEFAULT-demo` binding passed, and an unknown binding still
failed. Independent graph data stayed unchanged, and an unauthenticated request
was rejected. This verifies the alias path; stock PD/HStore startup,
non-default discovery, cross-space isolation and Kubernetes deployment remain
separate acceptance checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
