Postroggy commented on PR #3449: URL: https://github.com/apache/hugegraph/pull/3449#issuecomment-6612931810
@bitflicker64 Thanks for the review. I've pushed 857dd12c addressing the findings: - Restore existing master-key files to `0600` before Hubble starts, while preserving key bytes, lazy creation, and environment-key precedence. Symlinks are not followed, and chmod failures stop startup with an actionable error. - Document the one-time API-key re-entry on upgrade, persistence requirements, and stable UID/file ownership. - Add rendered-wrapper regression tests and wire them into the Helm CI checks. The managed property is also normalized to a single entry. Local validation: **344 Helm tests and 90 Python tests passed**, including 6 new Hubble tests covering 35 wrapper executions. The permission tests simulate the filesystem effect of `fsGroup`; they are not a live Kubernetes/CSI test. Also, to correct the earlier PR description: a missing master key is created on the next API-key save, not at Pod startup or during decryption. Could you please take another look at the updated head? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
