bitflicker64 commented on code in PR #3449:
URL: https://github.com/apache/hugegraph/pull/3449#discussion_r4458452617


##########
helm/hugegraph/templates/hubble-deployment.yaml:
##########
@@ -286,6 +296,8 @@ spec:
               value: {{ if $vermeerEnabled }}{{ printf "http://%s:%v"; (include 
"hugegraph.vermeer.masterName" .) .Values.vermeer.master.httpPort | quote }}{{ 
else }}""{{ end }}
             - name: HG_HUBBLE_VERMEER_TOKEN_FILE
               value: {{ if $vermeerEnabled 
}}"/var/run/hugegraph/vermeer/token"{{ else }}""{{ end }}
+            - name: HG_HUBBLE_TEXT2GQL_MASTER_KEY_FILE
+              value: "/hubble-data/text2gql-master.key"

Review Comment:
   One more data point for this thread: PD and Store in the same chart already 
default to `fsGroupChangePolicy: OnRootMismatch` (`helm/hugegraph/values.yaml` 
lines 111 and 240). The Hubble `fsGroup` guidance has no matching hint. Either 
of these would close the gap:
   - add the same hint (or default) for Hubble
   - `chmod 600` the key in the startup wrapper
   
   Supplying `HUBBLE_TEXT2GQL_MASTER_KEY` from a Secret via `hubble.extraEnv` 
is another documented option for non-root installs. That variable takes 
precedence over the key file.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to