Postroggy opened a new pull request, #3449: URL: https://github.com/apache/hugegraph/pull/3449
## Purpose of the PR No tracking issue. Found while deploying the chart: after a Hubble Pod is replaced, a Text2GQL model API key saved through the UI can no longer be used. ## Before → After Before: the image defaults `text2gql.shared.master_key_file` to `data/text2gql-master.key`, relative to the working directory `/hubble`. That path is not on the `/hubble-data` volume the chart mounts for the H2 database, so every Pod replacement generates a new master key and the API key already stored in H2 cannot be decrypted. The UI keeps showing a saved key but every generation fails. After: the startup wrapper writes `text2gql.shared.master_key_file=/hubble-data/text2gql-master.key`, rewriting a stale image default if one is present, so the master key lives on the same volume as H2. The variable is reserved, so `hubble.extraEnv` cannot move it back off the volume. No values, schema, or resource-shape changes. Images that do not read the property only log it as a redundant option. ## Main Changes - `helm/hugegraph/templates/hubble-deployment.yaml`: rewrite or append the property, and add `HG_HUBBLE_TEXT2GQL_MASTER_KEY_FILE`. - `helm/hugegraph/templates/_helpers.tpl`: add that variable to the reserved `hubble.extraEnv` names. - `helm/hugegraph/tests/hubble_text2gql_master_key_test.yaml`: cover the rendered environment and the reserved-name rejection. ## Validation - `helm template` with default values and the strict/cluster/single presets renders with only the new environment variable and property line. - `bash -n` passes on the rendered startup wrapper; a stubbed run appends the property once when absent and rewrites it without duplicating when present. - `helm unittest`: 343 passed, 1 failed. The failure is `tests/networkpolicy_test.yaml`, whose snapshot still records `helm.sh/chart: hugegraph-helm-0.3.0` while the chart is `0.4.0`; it fails the same way on a clean checkout. - `python3 -m unittest discover -s helm -p 'test_helm_*.py'`: 82 passed, 2 failed, both from the local environment (`GROOVY_JAR` unset; BSD `sed` on macOS for the Server entrypoint check). These are author-run results, not independent ASF acceptance; upstream CI will run separately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
