bitflicker64 commented on PR #3449: URL: https://github.com/apache/hugegraph/pull/3449#issuecomment-6632678382
## Review summary: R3 (FULL), head `85c0f78e` **Verdict: no blocking issues found. The code looks ready from this review's side; only a PR-description cleanup remains.** This round covers the full PR against the updated base `ed431fda`. That includes the `3bccd642` fix, which R2 did not review, and the master merge. Previous round: [R2 summary](https://github.com/apache/hugegraph/pull/3449#issuecomment-6613363847). With Hubble persistence enabled, a saved Text2GQL API key survives restarts and Pod replacement. Keys saved before this change need one re-entry after upgrading, which is documented. With `persistence.enabled=false`, the key and H2 are lost together on Pod replacement. - **R2 `chmod` failure blocking Hubble: fixed.** The wrapper now warns and starts Hubble; only Text2GQL is affected. [Thread](https://github.com/apache/hugegraph/pull/3449#discussion_r4459423422) - **R1 `fsGroup` permissions and upgrade docs:** still fixed, no regression. [Thread 1](https://github.com/apache/hugegraph/pull/3449#discussion_r4458407777), [Thread 2](https://github.com/apache/hugegraph/pull/3449#discussion_r4458407791) - **Merge with master:** clean. No master change in the shared Helm files was dropped or altered. - **[Minor]** The PR body still says Pod replacement "generates" a master key, still has an empty image placeholder, and still says "No values" changes. **Score: 9.5 / 10** (provisional, 2 of 4 reviews in). | Reviewer | Raw | Corrections | Adjusted | |---|---|---|---| | Reviewer A (gpt-6.1-terra) | 9.5 | none | 9.5 | | Reviewer C (model not reported) | 9.5 | none | 9.5 | **Checks:** one reviewer ran `test_helm_hubble.py` (6/6) and the related Vermeer and SeaTunnel suites, which all passed. `helm unittest` passed 408/409; the one failure is a stale `networkpolicy` snapshot that fails the same way on the base. Nothing was run on a live cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
