Postroggy commented on PR #3449:
URL: https://github.com/apache/hugegraph/pull/3449#issuecomment-6633114623
@bitflicker64 Thanks for the full R3 review. I've updated the PR description
to address the remaining cleanup:
- Corrected master-key creation to happen lazily on the next API-key save.
- Removed the empty image placeholder.
- Clarified that `values.yaml` changes are documentation comments only: no
new chart values, changed defaults or schema changes.
- Updated the behavior, upgrade guidance and validation details to match the
current head.
I've also resolved the three threads you confirmed were addressed.
Rechecked **`85c0f78e`**: **6/6 Hubble tests (37 wrapper executions)** and
**409/409 Helm tests (63 suites)** passed with the repository-pinned **Helm
3.16.2 / helm-unittest 1.0.0**.
For the NetworkPolicy snapshot observation, I independently compared the
four rendered policies at base `ed431fda` and head `85c0f78e`: they are
identical. Both render chart version `0.4.0`, while the committed snapshot
still records `0.3.0`, so that drift predates this PR. The test notes that
helm-unittest 1.0.0 skips full comparison for `matchSnapshot: {}` and checks
current metadata separately; I've made that limitation explicit in the PR body
alongside your 408/409 result.
No additional code changes were needed for R3. Thanks for checking the fixes
and the master merge.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
