rdblue commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268289533
##########
File path: api/src/main/java/org/apache/iceberg/FileFormat.java
##########
@@ -71,9 +71,9 @@ public static FileFormat fromFileName(CharSequence filename)
{
return null;
}
- private static int lastIndexOf(char c, CharSequence seq) {
+ private static int lastIndexOf(char ch, CharSequence seq) {
Review comment:
If you didn't know what they meant, then let's give them better names. This
is probably just a case where I'm familiar with the spec and I shouldn't assume
other people are.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
