rdblue commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268291553
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -313,8 +312,8 @@ private void checkAndAddPartitionName(String name) {
partitionNames.add(name);
}
- public Builder withSpecId(int specId) {
- this.specId = specId;
+ public Builder withSpecId(int newSpecId) {
Review comment:
I'd rather use `newSpecId` than `SuppressWarnings` for cases like this. But,
I agree that this makes things more awkward. I wish we could allow cases where
the field is assigned to an argument with the same name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
