rdblue commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268294680
##########
File path: api/src/main/java/org/apache/iceberg/types/TypeUtil.java
##########
@@ -369,23 +380,23 @@ public T get() {
static int decimalMaxPrecision(int numBytes) {
Preconditions.checkArgument(numBytes >= 0 && numBytes < 24,
- "Unsupported decimal length: " + numBytes);
+ "Unsupported decimal length: %d", numBytes);
Review comment:
Preconditions format should use only `%s`. See
https://github.com/google/guava/blob/master/guava/src/com/google/common/base/Preconditions.java#L100-L105
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
