rdblue commented on a change in pull request #143: Applies the Baseline plugin 
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268292608
 
 

 ##########
 File path: 
api/src/main/java/org/apache/iceberg/expressions/ResidualEvaluator.java
 ##########
 @@ -78,8 +78,8 @@ public Expression residualFor(StructLike partitionData) {
   private class ResidualVisitor extends 
ExpressionVisitors.BoundExpressionVisitor<Expression> {
     private StructLike struct;
 
-    private Expression eval(StructLike struct) {
-      this.struct = struct;
+    private Expression eval(StructLike arg) {
 
 Review comment:
   Could you update this to `structLike` instead of `arg`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to