rdblue commented on a change in pull request #143: Applies the Baseline plugin
for iceberg-api only.
URL: https://github.com/apache/incubator-iceberg/pull/143#discussion_r268290386
##########
File path: api/src/main/java/org/apache/iceberg/PartitionField.java
##########
@@ -68,11 +68,9 @@ public boolean equals(Object other) {
}
PartitionField that = (PartitionField) other;
- return (
- sourceId == that.sourceId &&
+ return sourceId == that.sourceId &&
Review comment:
I'm okay with this, but I don't see a lot of benefit to removing unnecessary
parens. If extra parens make something more readable (like this) or clarify
order of operations even when matching the default, I would say we should keep
them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
