rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r333186407
##########
File path: core/src/main/java/org/apache/iceberg/PartitionSpecParser.java
##########
@@ -33,14 +33,19 @@
import org.apache.iceberg.util.Pair;
public class PartitionSpecParser {
- private PartitionSpecParser() {
- }
+ private static final String DATA_FILE = "data_file";
+ private static final String NAME = "name";
+ private static final String TYPE = "type";
+ private static final String PARTITION = "partition";
private static final String SPEC_ID = "spec-id";
private static final String FIELDS = "fields";
private static final String SOURCE_ID = "source-id";
private static final String TRANSFORM = "transform";
- private static final String NAME = "name";
+ private static final String FIELD_ID = "field-id";
+
+ private PartitionSpecParser() {
+ }
Review comment:
Please remove any non-functional changes, like this one that moves the
private constructor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
