rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r361006669
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -48,8 +48,7 @@
* represented by a named {@link PartitionField}.
*/
public class PartitionSpec implements Serializable {
- // start assigning IDs for partition fields at 1000
- private static final int PARTITION_DATA_ID_START = 1000;
+ public static final int PARTITION_DATA_ID_START = 1000;
Review comment:
Also, why remove the comment?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
