rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r361007364
##########
File path: api/src/main/java/org/apache/iceberg/PartitionField.java
##########
@@ -71,7 +80,7 @@ public boolean equals(Object other) {
if (other == null || getClass() != other.getClass()) {
return false;
}
-
+ // not considering field id, as field-id will be reused.
Review comment:
ID will be reused, but assignment is consistent because we assume that
partition specs are not modified before the addition of partition field IDs.
That means that tables start with only one spec that might not have IDs.
Because we assign incrementally, IDs will always match when assigned using the
default (1000, 1001, etc.).
Because we do have consistent IDs, I think this should check field ID here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
