rdblue commented on a change in pull request #499: Add persistent IDs to
partition fields (WIP)
URL: https://github.com/apache/incubator-iceberg/pull/499#discussion_r336603541
##########
File path: api/src/main/java/org/apache/iceberg/PartitionField.java
##########
@@ -28,11 +28,13 @@
*/
public class PartitionField implements Serializable {
private final int sourceId;
+ private final int partitionFieldId;
private final String name;
private final Transform<?, ?> transform;
- PartitionField(int sourceId, String name, Transform<?, ?> transform) {
+ PartitionField(int sourceId, int partitionFieldId, String name, Transform<?,
?> transform) {
Review comment:
The name `partitionFieldId` is redundant because the class is
`PartitionField`.
Let's use the same convention that is used in types. The PartitionField
should have an `id` instance variable that is accessed by a `fieldId` method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
